[Webkit-unassigned] [Bug 95672] [EFL][WK2] Add javascript popup api.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95672





--- Comment #16 from Jinwoo Song <jinwoo7.song at samsung.com>  2012-09-09 02:56:09 PST ---
(From update of attachment 162985)
View in context: https://bugs.webkit.org/attachment.cgi?id=162985&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1579
> +    eina_stringshare_del(value);

Is this right to call eina_stringshare_del(value) here? It seems to return NULL always.

> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:51
> +    ewk_view_run_javascript_alert(toEwkView(clientInfo), alertTextString);

nit: Why don't you simplify the code like this?
ewk_view_run_javascript_alert(toEwkView(clientInfo), WKEinaSharedString(alertText));

> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:58
> +    return ewk_view_run_javascript_confirm(toEwkView(clientInfo), messageString);

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:66
> +    WKEinaSharedString value = ewk_view_run_javascript_prompt(toEwkView(clientInfo), messageString, defaultValueString);

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.