[Webkit-unassigned] [Bug 96114] [chromium] Make prioritized texture manager not touch backings array on the main thread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96114





--- Comment #11 from Adrienne Walker <enne at google.com>  2012-09-07 19:21:03 PST ---
(From update of attachment 162924)
View in context: https://bugs.webkit.org/attachment.cgi?id=162924&action=review

I was a little worried that this patch was going to put us back into the same old "split TextureManager" situation that we were in before (where we had one allocating/deleting class and one managing class), but this is a lot smaller and more elegant.  It's still one managing class, with plenty of asserts to make sure that we're working on data structures on the right thread.  Maybe I'm just a little bit wary of baking too much main thread vs. impl thread logic here when there's impl thread painting in the future.

> Source/WebCore/platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:384
> +    if (m_needsSortBackings && forceResort) {
> +        prioritizeBackings();
> +        ASSERT(!m_needsSortBackings);
> +    }

I don't follow this.  assertInvariants is for making sure that the sorting is correct.  It seems like you should either only assert when it's sorted or sort every time.  Why do you need to sometimes sort here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.