[Webkit-unassigned] [Bug 96127] JSC: Fix some llint C++ interpreter bugs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96127





--- Comment #6 from Filip Pizlo <fpizlo at apple.com>  2012-09-07 15:08:38 PST ---
(From update of attachment 162844)
View in context: https://bugs.webkit.org/attachment.cgi?id=162844&action=review

>> Source/WTF/wtf/Assertions.h:249
>> +static ALWAYS_INLINE void wtfAssert(bool assertion, const char* file, int line,
>> +                                    const char* function,
>> +                                    const char* assertionString)
> 
> WebKit style is not to indent lines like this, because it adds extra busy work to later edits to keep the lines equally indented. You can either put "function" and "assertionString" on the same line, indented by one tabstop, or you can put each of assertion, file, line, function, and assertionString on their own lines, indented by one tabstop.

I would have done:

static void wtfAssert(
    bool assertion, const char* file, int line,
    const char* function, const char* assertionString)

This works with emacs for me (using the stroustrup cc-mode style).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.