[Webkit-unassigned] [Bug 96126] Appcache fallback URL match should use the longest candidate

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 7 11:23:06 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96126





--- Comment #9 from Leo Yang <leoyang at rim.com>  2012-09-07 11:23:21 PST ---
(In reply to comment #7)
> (In reply to comment #5)
> > (From update of attachment 162801 [details] [details])
> 
> > > Source/WebCore/loader/appcache/ApplicationCache.cpp:42
> > > +struct FallbackURLGreaterThan {
> > > +    bool operator()(const std::pair<KURL, KURL>& lhs, const std::pair<KURL, KURL>& rhs)
> > 
> > Please just use a "static inline bool" function.
> > 
> 
> I would suggest the same, but not sure if it can be built with all STL providers and compilers.

Because we are going to use a function pointer, I think inline wouldn't help. And as Yong said, not sure if some compiler would complain.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list