[Webkit-unassigned] [Bug 96023] Expose ability to create WebUserMediaRequest from chromium side

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96023





--- Comment #14 from Adam Barth <abarth at webkit.org>  2012-09-07 10:11:33 PST ---
(From update of attachment 162632)
View in context: https://bugs.webkit.org/attachment.cgi?id=162632&action=review

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1009
> +    RefPtr<WebCore::NavigatorUserMediaSuccessCallback> requestSuccessCallback = WebCore::V8NavigatorUserMediaSuccessCallback::create(v8::Local<v8::Value>::New(successCallback), getScriptExecutionContext());

There's no need to call getScriptExecutionContext.  We can get that object directly from m_frame->document()

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1015
> +    RefPtr<WebCore::UserMediaRequest> request = WebCore::UserMediaRequest::create(m_frame->document(), userMedia, requestOptions, requestSuccessCallback, requestErrorCallback);

Notice that you're using m_frame->document() here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.