[Webkit-unassigned] [Bug 95488] [BlackBerry] when one of multiple tabs uses authentication, user can get the auth dialog while the other tab has focus.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95488





--- Comment #4 from Yong Li <yoli at rim.com>  2012-09-07 07:38:30 PST ---
(From update of attachment 162653)
View in context: https://bugs.webkit.org/attachment.cgi?id=162653&action=review

> Source/WebCore/ChangeLog:8
> +
> +        Add AuthenticationChallengeClient interface to support asynchronous

Better put the RIM PR number here, so we will be able to link the commit to the PR

> Source/WebCore/ChangeLog:16
> +        Note: this patch itself will not fix this bug, but it prepares the base
> +        for the next patch by making the authentication asynchronous to NetworkJob
> +        and MediaPlayerPrivateBlackBerry.

why not put them together? That will make it easier for reviewer to understand how it will work

> Source/WebCore/ChangeLog:18
> +        No new tests as there is no change of behavior.

Doing it in async mode is a big behavior change, with your next patch :) We don't have to upstream a layout test for our platform-specific test though.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:832
> +    if (result != AuthenticationChallengeSuccess
> +            || protectionSpace.host().isEmpty()
> +            || !url.isValid()) {

style: using one line is good enough?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.