[Webkit-unassigned] [Bug 95990] [EFL][WK2] Build warning : fix warning about extended initializer on EWK2UnitTestBase.cpp.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95990





--- Comment #6 from Byungwoo Lee <bw80.lee at samsung.com>  2012-09-07 01:01:17 PST ---
(In reply to comment #5)
> (From update of attachment 162680 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162680&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:44
> > +    static Ewk_View_Smart_Class ewkViewClass = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("Browser_View");
> > +    return ewkViewClass;
> 
> Did you test whether this is fine although test cases does not clear the methods ?

It's a good point. There was no regression with current test case.
But there can be some problem because ewk2UnitTestBrowserViewSmartClass() returns reference. (The initial data can be changed.)

Return by copying data will be better.

Thanks for pointing this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.