[Webkit-unassigned] [Bug 96001] [BlackBerry] Implement a color picker

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 6 12:33:37 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96001





--- Comment #5 from Crystal Zhang <haizhang at rim.com>  2012-09-06 12:33:51 PST ---
(In reply to comment #3)
> (From update of attachment 162544 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162544&action=review
> 
> > Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:52
> > +    source.append("<style>\n");
> 
> You should use appendLiteral() here, it is more efficient.
> 
> > Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:56
> > +    source.append("</style>\n<style>");
> 
> Ditto.
> 
> > Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:59
> > +    source.append("</style></head><body>\n");
> 
> Ditto.
> 
> > Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:60
> > +    source.append("<script>\n");
> 
> Ditto...
> 
> > Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:109
> > +    writer.addData(m_source.utf8().data(), m_source.utf8().length());
> 
> You should probably store m_source.utf8() in a local variable to avoid copying the string twice.
 We don't have appendLiteral() in blackberry port, so have to keep append().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list