[Webkit-unassigned] [Bug 96001] [BlackBerry] Implement a color picker

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 6 12:23:09 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96001


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162544|review?                     |review-
               Flag|                            |




--- Comment #4 from Rob Buis <rwlbuis at gmail.com>  2012-09-06 12:23:23 PST ---
(From update of attachment 162544)
View in context: https://bugs.webkit.org/attachment.cgi?id=162544&action=review

Looks good, but please address Antonio and my comments.

> Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.h:48
> +    void closePopup();

It seems many of these can be private.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list