[Webkit-unassigned] [Bug 90603] [EFL] Support the permission function of the Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90603





--- Comment #36 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-09-06 02:03:32 PST ---
(From update of attachment 162411)
View in context: https://bugs.webkit.org/attachment.cgi?id=162411&action=review

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:87
> +    m_cachedPermissions.add(domain, isAllowed);

isAllowed -> allowed ?

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:96
> +    iter->second->handleEvent(Notification::permissionString(isAllowed ? NotificationClient::PermissionAllowed : NotificationClient::PermissionDenied));

ditto.

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:98
> +    m_cachedPermissions.add(String::fromUTF8(ewk_security_origin_string_get(origin)), isAllowed);

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.