[Webkit-unassigned] [Bug 90603] [EFL] Support the permission function of the Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90603





--- Comment #29 from Kihong Kwon <kihong.kwon at samsung.com>  2012-09-05 19:14:55 PST ---
(In reply to comment #23)
> (From update of attachment 160621 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160621&action=review
> 
> > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:33
> > +    : m_view(view)
> 
> Check for null?
OK.
> 
> > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:64
> > +    Ewk_Security_Origin* origin = ewk_security_origin_new(context->securityOrigin());
> 
> shouldn't we check args for null here before usage?
Not exactly. context is already checked in the Notification::requestPermission.
Therefore we don't need check it here.
> 
> > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:80
> > +void NotificationPresenterClientEfl::addToPermissionCache(const String domain, const bool isAllowed)
> 
> const String& domain
You are right.
> 
> > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:84
> > +        return;
> 
> if (iter != m_cachedPermissions.end())
>    m_cachedPermissions.add(domain, isAllowed);
> 
> > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:90
> > +    PermissionRequestMap::iterator iter = m_pendingPermissionRequests.find(const_cast<Ewk_Security_Origin*>(origin));
> 
> maybe typedef HashMap<const Ewk_Security_Origin*, RefPtr<WebCore::NotificationPermissionCallback> > PermissionRequestMap; so that you do not need const_cast?
OK. It's better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.