[Webkit-unassigned] [Bug 95917] New: [chromium] Need a API to upload Android image resources from the embedder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95917

           Summary: [chromium] Need a API to upload Android image
                    resources from the embedder
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: trchen at chromium.org
                CC: jamesr at chromium.org, sievers at chromium.org


The edge effect layers need to acquire the glow textures from Android framework. (and potentially the shadow decoration needs it too? sievers@)

We can't do it from the WebKit side due to the lack of Dalvik VM access, so we need an API to upload it from the embedder side. Currently in my downstream code I add a new callback in WebWidgetClient like this:

class WebWidgetClient {
    // Android only. Used to retrieve drawable resources from system theme.
    virtual void getDrawableResources(WebImage* out, const char* name) { }
};

WebViewImpl::WebViewImpl(WebViewClient* client)
{
    WebImage glowImage;
    client->getDrawableResources(&glowImage, "android:drawable/overscroll_glow");
    m_edgeEffectPlatformLayer = EdgeEffectLayerChromiumAndroid::create(glowImage.getSkBitmap());
}

Not sure if it is the best way to implement the thing. Let's discuss how to upstream this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.