[Webkit-unassigned] [Bug 93998] [chromium] More Android changes to WebFrameImpl::selectRange

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93998


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #160944|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #7 from Adam Barth <abarth at webkit.org>  2012-09-05 11:08:39 PST ---
(From update of attachment 160944)
View in context: https://bugs.webkit.org/attachment.cgi?id=160944&action=review

I'd really like rniwa to take a look at this patch when he gets back from vacation.  Based on the discussion in the previous bug, this patch looks plausible to me, but I'm far from an expert here.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:-1482
> -    if (frame()->selection()->shouldChangeSelection(newSelection))

Looks like we lost this call.  Is this no longer needed?

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1486
> +    if (selection.isNone())
> +        return false;

Should this ASSERT?  Is it an error to call this function without a current selection?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.