[Webkit-unassigned] [Bug 95854] New: [Chromium] Compositor build errors prevent rolling Chromium into WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95854

           Summary: [Chromium] Compositor build errors prevent rolling
                    Chromium into WebKit
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit API
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: peter at chromium.org
                CC: jamesr at chromium.org


Example log:
http://build.webkit.org/builders/Chromium%20Linux%20Release/builds/58456/steps/compile-webkit/logs/stdio

In file included from ../../Source/WebKit/chromium/webkit/compositor_bindings/web_compositor_support_impl.cc:5:0:
../../Source/WebKit/chromium/webkit/compositor_bindings/web_compositor_support_impl.h:8:73: fatal error: third_party/WebKit/Source/Platform/chromium/public/WebLayer.h: No such file or directory

Include paths in web_compositor_support_impl.cc seem to be incorrect. Target range is 154695:154940, so I'm guessing r154819 is the issue here:
http://src.chromium.org/viewvc/chrome?view=rev&revision=154819

James, I don't know enough about this to quickly write up fixes. Could you confirm or correct the following assertions?

- There are two compositors, one in Chromium's cc/ directory, one in WebKit. The gyp "use_libcc_for_compositor" variable toggles this: 0 means WebKit, 1 means cc/.
- Chromium and WebKit currently both build with use_libcc_for_compositor=0. Are there bots which have use_libcc_for_compositor=1? Is there a bug or issue I can track for progress on this?

The canaries did not catch this error. The paths used on lines 21 to 31 of web_compositor_support_impl.cc cannot possibly work for WebKit, considering there is no such things as third_party/WebKit/ there.

Assuming we do need the "webkit_compositor_support" target itself, we need to change the include paths to work correctly under all scenarios. I'll prepare a patch for fixing this on the Chromium side..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.