[Webkit-unassigned] [Bug 95649] Web Inspector: CodeGeneratorInspector.py: support asynchronous command implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95649


Andrey Adaikin <aandrey at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aandrey at chromium.org




--- Comment #15 from Andrey Adaikin <aandrey at chromium.org>  2012-09-05 05:24:36 PST ---
(In reply to comment #12)
> > > Source/WebCore/inspector/CodeGeneratorInspector.py:1873
> > > +        bool isActive();
> > bool isActive() const;
> > > Source/WebCore/inspector/CodeGeneratorInspector.py:1956
> > > +    bool isActive() { return m_inspectorFrontendChannel; }
> > bool isActive() const {...}
> 
> Can you justify this with a positive reason? I don't see a lot of const/mutable semantics for InspectorBackendDispatcher class.

Because it's a constant getter by it's nature that will not modify the class's internal state? :) Why not say about it to the compiler and a reader of the code? In fact, IMO, more logical question would be "Can you justify NOT using const here with a positive reason?" :) Can you?

Anyway, I'm not insisting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.