[Webkit-unassigned] [Bug 95838] New: Remove en_GB from quote handling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95838

           Summary: Remove en_GB from quote handling
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: nickshanks at nickshanks.com


Since en_GB inherits from en, there is no reason to specify identical values for quotations (added in r125476). The second of each of these pairs of lines should be removed, and the expected results regenerated. Sorry, but I can't generate a patch at the moment as I don't have the code on my work computer.


Source/WebCore/rendering/RenderQuote.cpp:

QUOTES_LANG("en",            "\x201c", "\x201d", "\x2018", "\x2019");
QUOTES_LANG("en-GB",         "\x201c", "\x201d", "\x2018", "\x2019");


LayoutTests/fast/css-generated-content/quotes-lang-expected.html:

:root:lang(en),       :not(:lang(en)) > :lang(en)             { quotes: '\201c' '\201d' '\2018' '\2019' }
:root:lang(en-GB),    :not(:lang(en-GB)) > :lang(en-GB)       { quotes: '\201c' '\201d' '\2018' '\2019' }

<q lang="en"><q>en</q></q>
<q lang="en-GB"><q>en-GB</q></q>


LayoutTests/fast/css-generated-content/quotes-lang.html:

<q lang="en"><q>en</q></q>
<q lang="en-GB"><q>en-GB</q></q>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.