[Webkit-unassigned] [Bug 95614] Add support for blendmode to platform code for mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95614


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161837|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com>  2012-09-04 16:54:41 PST ---
(From update of attachment 161837)
View in context: https://bugs.webkit.org/attachment.cgi?id=161837&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1081
> +#if ENABLE(CSS_COMPOSITING)
> +    if (m_uncommittedChanges & CompositingChanged)
> +        updateLayersCompositing();
> +#endif

I think it's very confusing to use the term "compositing" in code which is all about accelerated compositing. Maybe use "blending" instead?

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2782
> +void GraphicsLayerCA::updateLayersCompositing()

This should become updateBlending() or updateBlendMode(). The 'layer' in the name is redundant.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:383
> +        CompositingChanged = 1 << 26,

blending.

> Source/WebCore/rendering/RenderLayerBacking.cpp:253
> +void RenderLayerBacking::updateLayerBlendMode(const RenderStyle* style)

'layer' here is redundant.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.