[Webkit-unassigned] [Bug 95579] [chromium] Need to rebaseline chromium tests after hidpi changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 4 10:45:17 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=95579





--- Comment #8 from alexst at chromium.org  2012-09-04 10:45:30 PST ---
(In reply to comment #7)
> Don't rebaseline the broken image icons in this patch since the new baselines are wrong.  Instead, mark (or leave the marked) as expected failures with a link to the correct bug.

I could do that, but I think it will be a bit confusing for whoever will work on the hidpi broken image.

The new baseline is no more wrong than the one it replaces as far as the broken image is concerned. If I leave them marked as broken, the test will fail because the resolutions mismatch, not because the old test had the correct image and the new one didn't.

If anything, I think it would make more sense to rebaseline them with Mac versions of the 1600x1200 images and then mark as broken with a new bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list