[Webkit-unassigned] [Bug 95672] [EFL][WK2] Add javascript popup api.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95672





--- Comment #6 from Byungwoo Lee <bw80.lee at samsung.com>  2012-09-04 06:59:58 PST ---
(From update of attachment 161938)
View in context: https://bugs.webkit.org/attachment.cgi?id=161938&action=review

>>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:276
>>>> +    destination->alert.message = strdup(source->alert.message);
>>> 
>>> Should use eina_stringshare_ref() instead of strdup().
>> 
>> Should this structure be changed to using eina stringshare because of this test case code?
>> Actually test case just use this structure to keep the strings for checking,
>> and can use some other way or define other structure for keeping the data.
>> 
>> If strdup in test case is a problem, how about changing the test case code?
> 
> The point is that the application may need to "copy" the strings in the structure as well. And using eina_stringshare_ref() should be more efficient than strdup(). As far as I know, we never expose "raw" strings to the client so it knows it can safely can eina_stringshare_ref() on them.

Ok~ I understood your point, and found that all the other exposed string is the stringshared.
I'll apply those. Thanks for your guide :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.