[Webkit-unassigned] [Bug 95710] New: [nrwt] Harden against empty stdout/stderr after stopping a crashed/timeouted driver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95710

           Summary: [nrwt] Harden against empty stdout/stderr after
                    stopping a crashed/timeouted driver
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: kbalazs at webkit.org
                CC: dpranke at chromium.org


It has been revealed when I tested a patch that makes a lot of tests failing. In driver.run_test an exception can raise here: 

if stop_when_done or crashed or timed_out:
    # We call stop() even if we crashed or timed out in order to get any remaining stdout/stderr output.
    # In the timeout case, we kill the hung process as well.
    out, err = self._server_process.stop(self._port.driver_stop_timeout() if stop_when_done else 0.0)
    text += out
    self.error_from_test += err

at the += if out or err is None.

Although it probably not shown on trunk we should make sure the harness can handle a driver in a bad state.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.