[Webkit-unassigned] [Bug 95618] [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95618


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161899|                            |review?
               Flag|                            |




--- Comment #1 from Mario Sanchez Prada <msanchez at igalia.com>  2012-09-03 04:44:11 PST ---
Created an attachment (id=161899)
 --> (https://bugs.webkit.org/attachment.cgi?id=161899&action=review)
Patch proposal

Simple patch to fix this issue, by protecting us against the situation exposed here: a selector which is not rendered through a HTML <select> element.

I propose this patch because the current code was assuming that was the case (a HTML <select> element was always there), which seems to be plainly wrong, as this situation clearly exposes. Of course, some better improvements could be done (e.g. supporting WAI-ARIA selectors), but I think the focus should be now put on fixing this crash, and so that's what this patch does, by ensuring we only emit the signal when such an assumption is right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.