[Webkit-unassigned] [Bug 95669] [EFL] Use WebKitVersion.h to get version information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95669





--- Comment #4 from Jinwoo Song <jinwoo7.song at samsung.com>  2012-09-03 01:37:47 PST ---
(In reply to comment #2)
> (From update of attachment 161874 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161874&action=review
> 
> > Source/WebKit/efl/ewk/ewk_settings.cpp:320
> > +    WTF::String uaVersion = makeString(String::number(WEBKIT_MAJOR_VERSION), '.', String::number(WEBKIT_MINOR_VERSION), '+');
> 
> Use String operator instead of makeString() ?
> 
> str = text + 'a' + foo + bar;
> 
> This is more efficient way to concatenate strings.
> 
> See also : http://trac.webkit.org/wiki/EfficientStrings
Done.
> 
> > Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp:55
> > +    version = makeString(String::number(WEBKIT_MAJOR_VERSION), '.',
> 
> ditto.
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.