[Webkit-unassigned] [Bug 95669] [EFL] Use WebKitVersion.h to get version information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95669





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-09-03 01:16:21 PST ---
(From update of attachment 161874)
View in context: https://bugs.webkit.org/attachment.cgi?id=161874&action=review

> Source/WebKit/efl/ewk/ewk_settings.cpp:320
> +    WTF::String uaVersion = makeString(String::number(WEBKIT_MAJOR_VERSION), '.', String::number(WEBKIT_MINOR_VERSION), '+');

Use String operator instead of makeString() ?

str = text + 'a' + foo + bar;

This is more efficient way to concatenate strings.

See also : http://trac.webkit.org/wiki/EfficientStrings

> Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp:55
> +    version = makeString(String::number(WEBKIT_MAJOR_VERSION), '.',

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.