[Webkit-unassigned] [Bug 100851] [V8] use toV8Fast in all relevant Node getters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100851





--- Comment #3 from Dan Carney <dcarney at google.com>  2012-10-31 09:05:03 PST ---
(From update of attachment 171640)
View in context: https://bugs.webkit.org/attachment.cgi?id=171640&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:297
>> +    die("IsDOMNodeType is out of date with respect to $interfaceName") if IsDOMNodeType($interfaceName) != IsNodeSubType($dataNode);
> 
> Why are both IsDOMNodeType() and IsNodeSubType() needed, given that they should return the same result?

One is only useful for the currently executing dataNode. The other can check the DOMNode-iness of anything based on name.

>> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1121
>>          push(@implContentDecls, "    return toV8Fast($result, info, imp);\n");
> 
> Some Node-type classes have custom implementation of toV8() in bindings/v8/custom/*. Wouldn't it cause a problem? I mean, if you call toV8Fast() here, you might end up failing to call custom toV8().

Yep.  Fix on its way.

>> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:-4031
>> -    return 1 if $type eq 'HTMLTableSectionElement';
> 
> Isn't IsDOMNodeType() used by other places? I want to make sure that this change won't affect other places.

It's used in a few other places. I can check it out, but it's pretty poorly named if this update is not correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.