[Webkit-unassigned] [Bug 100219] [WK2][WTR] Text input controller needs firstRectForCharacterRange implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100219





--- Comment #7 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-10-31 03:19:51 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 171459 [details] [details])
> > I do not think that this is the right approach. the goal here is to test API on UI process side. If you add a separate implementation just for testing, and then break the one in WebPageProxy, the regression test won't notice that.
> 
> This is done for WebKitTestRunner. See discussion on https://bugs.webkit.org/show_bug.cgi?id=99438. All functions in TextInputController uses WKBundle... functionality which uses WebPage. For API on UI process (in mac) everything should be the same. There is a lot of functions like setTracksRepaints which are accessible from API and through bundle. Do you suggest to make all my changes as functionForTesting ?

Like ap said. Some tests are for testing functionality in the engine, others are for testing that public API works correctly.

In WebKit we are trying to split these test up so that those testing the engine use internals methods (shared across ports) where as others will use the testRunner methods (per port).

This is not finished so many in the former category are implemented using testRunner.

So basically you need to find out which group these tests belong in. If they are for testing API they should should call to public API methods and not implement them in the testRunner itself.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.