[Webkit-unassigned] [Bug 100633] Text Autosizing: Add Text Autosizing APIs for WK2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100633





--- Comment #11 from Jaehun Lim <ljaehun.lim at samsung.com>  2012-10-30 23:56:40 PST ---
(In reply to comment #10)
> (From update of attachment 171548 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171548&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPreferences.h:229
> > +// Defaults to 1.0
> > +WK_EXPORT void WKPreferencesSetTextAutosizingFontScaleFactor(WKPreferencesRef preferences, float fontScaleFactor);
> > +WK_EXPORT float WKPreferencesGetTextAutosizingFontScaleFactor(WKPreferencesRef preferences);
> 
> All the other preferences use double, why use float here?  I'd prefer we keep it consistent and use double.

"Text Autosizing" uses float variable for font scale factor. So I just conform to its implementation.

Using double instead of float in my patch is trivial. But I think it's strange to use different types between WebCore::Settings and WebKit::Preferences.

If using double is a concrete rule. I'll follow.

John, how about using double instead of float in Text Autosizing ?
Text Autosizing is only feature using float in Settings. :(
If you agree, I will fix.

Sam, this is just my curiosity, is there any technical reasons to use double instead of float ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.