[Webkit-unassigned] [Bug 100155] Full-page PDFPlugin should support inline form editing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 30 23:43:22 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=100155





--- Comment #10 from Tim Horton <timothy_horton at apple.com>  2012-10-30 23:44:40 PST ---
Thanks for the review, Dan!

(In reply to comment #9)
> > Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:96
> > +    IntSize documentSize([m_pdfLayerController contentSizeRespectingZoom]);
> > +    IntPoint scrollPosition([m_pdfLayerController scrollPosition]);
> 
> I’d use = and property notation here.

It seems I then need to use the IntSize/Point constructor explicitly? That seems uglier.

> > Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:64
> > +    default:
> 
> Not case NSNaturalTextAlignment?

Hmm, sure.

> > Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:65
> > +        return "inherit";
> 
> Not -webkit-start?

What?

> What about setting the dir attribute or the direction CSS property?

I don't know where I'd get the direction from. I wonder if PDF supports that (it must!).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list