[Webkit-unassigned] [Bug 100303] [EFL] Fix failure to highlight nodes on web inspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 30 22:52:26 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=100303


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #170836|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-10-30 22:53:44 PST ---
(From update of attachment 170836)
View in context: https://bugs.webkit.org/attachment.cgi?id=170836&action=review

>> Source/WebKit/efl/ewk/ewk_view_single.cpp:276
>> +    if (page) {
> 
> WebKit prefers to use early return.

As we talk in private, we can't return early in this case. If we do early return, remaining functions won't be called.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list