[Webkit-unassigned] [Bug 100633] Text Autosizing: Add Text Autosizing APIs for WK2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100633





--- Comment #8 from Jaehun Lim <ljaehun.lim at samsung.com>  2012-10-30 16:40:41 PST ---
(In reply to comment #7)
> (From update of attachment 171168 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171168&action=review
> 
> Looks fine to me. I'm not a WebKit reviewer though, nor am I familiar with WebKit2, so best to find a reviewer there.
> 
> Kenneth, could you suggest a reviewer for this perhaps?
> 
> > Source/WebKit2/UIProcess/API/C/WKPreferences.cpp:949
> > +#if ENABLE(TEXT_AUTOSIZING)
> 
> I can't see any other preferences in this file which are guarded by feature defines. For example WKPreferencesSetWebArchiveDebugModeEnabled isn't guarded, even though setWebArchiveDebugModeEnabled is behind ENABLE(WEB_ARCHIVE) in WebCore/page/Settings.h. Are you sure WebKit2 style isn't to have these preferences always gettable/settable, even if their feature is disabled at compile time? (though I agree that this way makes sense)

It seems like no problem to remove guards. I'll upload new patch soon.

> 
> > Source/WebKit2/UIProcess/cf/WebPreferencesCF.cpp:96
> > +static void setFloatValueIfInUserDefaults(const String& identifier, const String& baseKey, WebPreferencesStore& store)
> 
> Are the setFloatValueIfInUserDefaults functions needed because FOR_EACH_WEBKIT_FLOAT_PREFERENCE is no longer empty? If so that seems reasonable.

Yes, you are right. I want to split them from this patch, but I can't as I said my previous comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.