[Webkit-unassigned] [Bug 100066] [WK2] Add APIs to get/set encoding detector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100066


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #171403|review?                     |review+
               Flag|                            |




--- Comment #14 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-10-30 05:33:16 PST ---
(From update of attachment 171403)
View in context: https://bugs.webkit.org/attachment.cgi?id=171403&action=review

> Source/WebKit2/UIProcess/API/C/WKPreferences.cpp:947
> +void WKPreferencesSetUsesEncodingDetector(WKPreferencesRef preferencesRef, bool use)

To be consistent with existing APIs, it would be good if you use *enabled* or *flag* instead of *use*.

> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:274
> +Eina_Bool ewk_setting_uses_encoding_detector_set(Ewk_Settings* settings, Eina_Bool use)

ditto. In this case, enable ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.