[Webkit-unassigned] [Bug 100628] Remove an un-necessary connection to X-Server

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100628





--- Comment #4 from Kalyan <kalyan.kondapally at intel.com>  2012-10-30 03:41:23 PST ---
(In reply to comment #3)
> (From update of attachment 171159 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171159&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        for gaining access to the screens in the display.Immediately(in constructor itself)
> > +        we ask the display from offscreenwindow.
> 
> Space before Immediately and before the (. Maybe it should be on a new line
> 
> Try to make the changelogs easy readable
> 
> > Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:133
> >          , m_hasAlpha(false)
> >      {
> >          GLXContext shareContextObject = 0;
> > -        m_display = XOpenDisplay(0);
> > +        m_display = m_offScreenWindow.display();
> 
> sorry is m_offScreenWindow initialized here? it is not in the initializer list
m_offScreenWindow is a member variable of GraphicsSurfacePrivate. 
It is created here and increments refcount (static member variable) in its constructor.
It would create a window and open connection to display on calls to 
getXWindow () and display () respectively.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.