[Webkit-unassigned] [Bug 100173] Re-order variables in BidiRun and LayoutState

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100173





--- Comment #7 from Eric Seidel <eric at webkit.org>  2012-10-29 22:07:41 PST ---
(From update of attachment 171361)
View in context: https://bugs.webkit.org/attachment.cgi?id=171361&action=review

> Source/WebCore/rendering/LayoutState.h:116
>      bool m_clipped;
>      bool m_isPaginated;

If we're saving memory, why not make these bitfields?

> Source/WebCore/platform/text/BidiResolver.h:152
> +    bool m_hasHyphen; // Used by BidiRun subclass; packed here to save space.

This might be considered a layering violation, since the whole idea with BidiCharacterRun is to allow paltform-only code to be able to use WebCore's bidi-resolver.  BidiRun, etc. are the DOM-aware subclasses.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.