[Webkit-unassigned] [Bug 100173] Re-order variables in BidiRun and LayoutState

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100173





--- Comment #6 from Abhishek Arya <inferno at chromium.org>  2012-10-29 20:17:21 PST ---
(From update of attachment 171361)
View in context: https://bugs.webkit.org/attachment.cgi?id=171361&action=review

> Source/WebCore/rendering/LayoutState.h:119
> +    bool m_dummy;

Do you really need this m_dummy ?

> Source/WebCore/ChangeLog:8
> +        Saves 8 bytes out of 48 per BidiRun on 64-bit.

Please do explain like "Saves 8 bytes out of 48 per BidiRun on 64-bit by packing boolean m_hasHyphen in parent class BidiCharacterRun". Also, please explain how reordering in LayoutState helps to improve security (like which vars are directly controller by attacker and what breaks the exploit). This explanation really helps people to understand this change and also prevent from making changes to it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.