[Webkit-unassigned] [Bug 100257] Don't fire requestAnimationFrame for scripts in frames that are out of view

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100257





--- Comment #8 from Darin Adler <darin at apple.com>  2012-10-29 10:26:44 PST ---
(From update of attachment 171278)
View in context: https://bugs.webkit.org/attachment.cgi?id=171278&action=review

> Source/WebCore/dom/ScriptedAnimationController.cpp:123
> +    if (view && view->windowClipRect(false).isEmpty()) {
> +        scheduleAnimation();
> +        return;
> +    }

Two things seem not quite right to me.

1)  I don’t think that windowClipRect(false).isEmpty() is the correct visibility check; I can’t find any other code that’s using that and this can’t be the only place we care about visibility.
2) I don’t think that polling is the right way to detect when the frame becomes visible again. We want to actively trigger it rather than running the timer over and over again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.