[Webkit-unassigned] [Bug 100235] [V8] Remove ScriptController::windowShell()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100235





--- Comment #11 from Dan Carney <dcarney at google.com>  2012-10-29 09:21:43 PST ---
> This is very unlikely to be the right thing.  I don't really understand the issue.  Why were we creating more contexts than we should have?  The way this worked before is that we'd always try to initialize things, and that would bail out early if the context was already initialized.  It seems odd that we'd end up calling v8::Context::New multiple times.

The reason this has changes is that I have moved V8DOMWindowShell initialization into ScriptController.  In fact almost all functions in V8DOMWindowShell are now only called by ScriptController function. The previous implementation managed to not init the window shell during FrameLoader::init(), which is when a frame is initially attached but instead on frame access, which is what we want. An empty frame that is never used (as in the failing test), does not need to init the context. I have implemented that same workaround in this time around in ScriptController::updateDocument, albeit with slightly different logic, since I do in ScriptController rather than in the window shell.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.