[Webkit-unassigned] [Bug 99213] [ARMv7] Neither linkCall() nor linkPointer() should flush code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99213





--- Comment #15 from Yong Li <yoli at rim.com>  2012-10-29 08:04:34 PST ---
(In reply to comment #13)
> (From update of attachment 169195 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169195&action=review
> 
> I remove the review flag for now.
> I think this is a nice patch but I would really like it to be completely generic. ARM is not the only platform without completely consistent caches.
> 
> I think we should follow Gavin's advices here. Yong, any opinion?
> 

I still think it is an ARMV-v7 only bug, as none of other assemblers' linkCall/linkPointer does cache flushing, nor ARMv7's linkJump() does. So it is very clear to me it is just an independent bug rather than a generic optimization. I could modify the changelog if needed.

We can create another bug for the potential duplicate cache flushing during "repatching".

So I'll add back the review request.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.