[Webkit-unassigned] [Bug 100598] [EFL][AC] Fix bugs preventing us from running layout tests with AC turned on

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100598





--- Comment #12 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-10-29 07:03:21 PST ---
(In reply to comment #11)
> (In reply to comment #4)
> > (From update of attachment 171211 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=171211&action=review
> > 
> > > Tools/EWebLauncher/main.c:810
> > > +#ifdef WTF_USE_ACCELERATED_COMPOSITING && defined HAVE_ECORE_X
> > 
> > I feel this is more readable:
> > #if defined(WTF_USE_ACCELERATED_COMPOSITING) && defined(HAVE_ECORE_X)
> 
> While we're at it, and I don't mean to halt the cq+, but shouldn't the first part be 
> #if USE(ACCELERATED_COMPOSITING)?

As far as I know, we have to use USE(XXX) macro in WebKit inside because this macro is defined in Platform.h file.  So, it seems to me that Tools can't use this.  However, if Tools can use this, I think it is better to use USE() macro. To my quick search, Tools can use it. Yael, could you check this ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.