[Webkit-unassigned] [Bug 98874] [GTK] WebKitWebView doesn't notify of favicon changes for known favicons but new pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98874





--- Comment #18 from Mario Sanchez Prada <mario at webkit.org>  2012-10-29 01:35:23 PST ---
(In reply to comment #17)
> (In reply to comment #15)
> > (From update of attachment 168732 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=168732&action=review
> > 
> > This seems reasonable in general, I just have a few comments and questions.
> > Still somebody else needs to have a look at it, and I'd like to test the
> > full thing (ephy patches included) before pushing it.
> 
> As I said, the patch looks good to me as well. About the patches for ephy, those currently in [1] are already updated to take into account the patch being proposed here, so it's easy to try it out.
> 
> As for me, I've just tried them out right now and I can confirm they work fine for me.
> 
> [1] https://bugzilla.gnome.org/show_bug.cgi?id=679370

Ping reviewers? This patch has been almost for 2 weeks here with no feedback and I think it would be good if we could move things forward, not to let it bitrot too much.

The patch works fine for me and makes possible to port one of epiphany's most visible missing features when using WK2, both in release and debug builds, so I don't see any reason why we shouldn't give it some love already, if time permits.

Thanks in advance.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.