[Webkit-unassigned] [Bug 100552] Regression(r132647) - enable Webgl in EwkView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100552


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #171019|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-10-26 15:59:37 PST ---
(From update of attachment 171019)
View in context: https://bugs.webkit.org/attachment.cgi?id=171019&action=review

> Source/WebKit2/ChangeLog:8
> +        Webgl is enabled with http://trac.webkit.org/changeset/132627.

WebGL*

> Source/WebKit2/ChangeLog:9
> +        But some of the changes seem lost after http://trac.webkit.org/changeset/132647.

seems is a bit vague, you need to make us confident of your change

>> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:128
>> +    //Enable Webgl Support
> 
> Should have a space between // and comment  [whitespace/comments] [4]

This comments should be actual sentences. Ie. a space after // and a punctuation mark at the end. In this case the comment doesn't add any value, so it should be removed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.