[Webkit-unassigned] [Bug 100235] [V8] Remove ScriptController::windowShell()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100235





--- Comment #8 from Adam Barth <abarth at webkit.org>  2012-10-26 15:57:45 PST ---
> Adam, the comments you've made have been addressed. The failing test was timing out because ScriptController::updateDocument() was causing unnecessary calls to v8::Context::New (2X the number needed), which it apparently a very slow process.

Uh...  Yes!  We don't want to call v8::Context::New any extra times.  It's not that it is slow.  We don't wan to to be making extra context objects!

> To fix this I added the below clause:
> 
> void ScriptController::updateDocument()
> {
>     if (!m_frame->loader()->frameHasLoaded())
>         return;
> 
> I really have no particular idea if this is the correct solution here or if there is a more appropriate check, but this solution at least passes all the tests in debug.

This is very unlikely to be the right thing.  I don't really understand the issue.  Why were we creating more contexts than we should have?  The way this worked before is that we'd always try to initialize things, and that would bail out early if the context was already initialized.  It seems odd that we'd end up calling v8::Context::New multiple times.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.