[Webkit-unassigned] [Bug 100235] [V8] Remove ScriptController::windowShell()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 26 15:54:14 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=100235





--- Comment #7 from Adam Barth <abarth at webkit.org>  2012-10-26 15:55:24 PST ---
(From update of attachment 170898)
View in context: https://bugs.webkit.org/attachment.cgi?id=170898&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3421
> +        if (frame->script()->initializeMainWorld()) {

There's no "IfNeeded" here?

> Source/WebCore/bindings/v8/ScriptController.cpp:328
> +static DOMWrapperWorld* existingWindowShellWorkaroundWorld()

Sometimes we use the name "depreciated" in functions we don't want more people to call, but this is fine too.

> Source/WebCore/bindings/v8/ScriptController.cpp:720
> +    if (!m_frame->loader()->frameHasLoaded())
> +        return;

What is this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list