[Webkit-unassigned] [Bug 99578] [EFL] Share WebKit-Gtk's Accessibility implementation with others WebKit ports.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99578





--- Comment #9 from Alejandro Piñeiro <apinheiro at igalia.com>  2012-10-26 04:33:18 PST ---
(In reply to comment #7)
> Created an attachment (id=170876)
 --> (https://bugs.webkit.org/attachment.cgi?id=170876&action=review) [details]
> 1. Isolate the GTK/Gail/Pango specific code in accessibility/gtk
> 
> (In reply to comment #6)
> > [...]
> > I completely agree with you. IMHO it looks like  WebCore methods could be used (like TextIterator) instead of gail_text_util_get_text(). 
> > The current implementation already uses it and based on Range (WebCore/dom/Range.h) we could manipulate TextIterator object in the same
> > way as gail is doing.
> 
> I'm attaching a quick patch I did by adding some #if PLATFORM(GTK) (and removing 'GTK' from some comments too) as a starting point, in order to show which parts inside accessibility/gtk are really depending on GTK+/Gail/Pango and which ones can be already shared with other ports, as they are just depending on GLib and ATK.

Seems a good starting point, thanks for it.

> As you can see the big deal is the implementation of atk_text_get_text*() functions, in WebKitAccessibleInterfaceText.cpp, and finding the parent accessible object for the root AtkObject, in WebKitAccessibleWrapperAtk.cpp. For the later, I'm afraid there're no big chances we can reuse things so we probably won't be able to get rid of that "#if PLATFORM" there, but for the atk_text_get_text*() functions I think that the implementation needed for EFL could be reused for GTK too, helping WebKitGtk+ get rid of Pango/Gail dependencies there, which would be a big win.

Yeah, probably it would be hard to remove the GTK specific code in order to get the parent. Anyway, this is just one method, and most of the gtk specific code are the text related methods.

> What do you think? If you think this makes sense, the remaining step for making the patch for this bug complete would be just to rename the directory to atk and update the makefiles.

That is your next patch ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.