[Webkit-unassigned] [Bug 82315] [Texmap][EFL] Implementation of AC related functions in ChromeClientEfl and ewkView.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82315





--- Comment #21 from Hyowon Kim <hw1008.kim at samsung.com>  2012-10-26 01:53:00 PST ---
(In reply to comment #16)
> (From update of attachment 170795 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170795&action=review
> > Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:611
> > +    return AllTriggers;
> As a curiosity, Doesn't we need options to choose features ?

To check options from settings would be needed.
I think it would be better to make a new bug to deal with it.

> > Source/WebKit/efl/ewk/ewk_view.cpp:4514
> > +static void _ewk_view_accelerated_compositing_cb(void* data, Evas_Object* object)
> (void* data, Evas_Object*) looks enough.

Done.

> > Source/WebKit/efl/ewk/ewk_view.cpp:4519
> > +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv);
> If this use only priv, why don't you just send priv as data.

Done.

> > Source/WebKit/efl/ewk/ewk_view.cpp:4527
> > +void _ewk_view_accelerated_compositing_context_create_if_needed(Evas_Object* ewkView)
> static?

My C++ habit. I've removed it.

> > Source/WebKit/efl/ewk/ewk_view.cpp:4566
> > +WebCore::GraphicsContext3D* ewk_view_accelerated_compositing_context_get(Evas_Object* ewkView)
> This function returns GraphicsContext3D.

Any problem?

> > Source/WebKit/efl/ewk/ewk_view.cpp:4592
> > +        _ewk_view_accelerated_compositing_context_create_if_needed(ewkView);
> > +        evas_object_show(priv->compositingObject);
> > +    } else
> > +        evas_object_hide(priv->compositingObject);
> > +
> > +    priv->acceleratedCompositingContext->attachRootGraphicsLayer(rootLayer);
> acceleratedCompositingContext are used, irrespective of compositingActive

The acceleratedCompositingContext should always know the current root layer.
If compositingActive is false, because the root layer is 0, we should also pass 0 to acceleratedCompositingContext.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.