[Webkit-unassigned] [Bug 100386] [Qt] Enable JSC's disassembler on x86, x86_64 Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100386


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #170671|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2012-10-26 00:28:47 PST ---
(From update of attachment 170671)
View in context: https://bugs.webkit.org/attachment.cgi?id=170671&action=review

LGTM, but I suggest to use an if() before landing.

> Source/JavaScriptCore/DerivedSources.pri:108
> +linux-*:isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64") {

I suggest to write this as

    linux-*:if(isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64")) {

to be on the very safe side.

> Source/JavaScriptCore/JavaScriptCore.pri:42
> +linux-*:isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64") {

Same here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.