[Webkit-unassigned] [Bug 100066] [EFL][WK2] Add APIs to get/set the encoding detector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100066


Ryuan Choi <ryuan.choi at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ryuan.choi at samsung.com




--- Comment #7 from Ryuan Choi <ryuan.choi at samsung.com>  2012-10-25 22:17:42 PST ---
(In reply to comment #5)
> (From update of attachment 170062 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170062&action=review
> 
> >>> Source/WebKit2/UIProcess/API/C/WKPreferences.h:223
> >>> +// Defaults to false.
> >> 
> >> IMHO, it depends on policy. So I would like to remove this comment.
> > 
> > There are default values for each setting member variables in Setting.cpp. I think its common to comment it.
> 
> If we set this setting value true on ewk initialization step, as an example, this function should return true.
> It means it is port specific.
> 
> Then, caller might have confusion between this comment and actual result.
> Actually, there was a discussion to enable encoding detector by default in efl port even though it hasn't been happened. :)

If someone changes default value, they should update doxygen also.

I supports jinwoo and chris.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.