[Webkit-unassigned] [Bug 100066] [EFL][WK2] Add APIs to get/set the encoding detector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100066





--- Comment #6 from Christophe Dumez <christophe.dumez at intel.com>  2012-10-25 21:46:40 PST ---
(In reply to comment #4)
> (From update of attachment 170062 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170062&action=review
> 
> >> Source/WebKit2/UIProcess/API/C/WKPreferences.h:223
> >> +// Defaults to false.
> > 
> > IMHO, it depends on policy. So I would like to remove this comment.
> 
> There are default values for each setting member variables in Setting.cpp. I think its common to comment it.

I agree with Jinwoo here. It is good (and common practice) to document the default value (even if ports can override it). Ports document their default values in their port-specific API anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.