[Webkit-unassigned] [Bug 100210] [BlackBerry] Support pixel tests for BlackBerry DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100210





--- Comment #3 from Xiaobo Wang <xiaobo.wang at torchmobile.com.cn>  2012-10-25 21:08:48 PST ---
(From update of attachment 170605)
View in context: https://bugs.webkit.org/attachment.cgi?id=170605&action=review

>> Source/WebKit/ChangeLog:8
>> +        Adds a step to build ImageDiff from Qt for DRT.
> 
> In general you probably want to credit Chris Wells, he did most of this patch AFAIK.

OK.

>> Tools/DumpRenderTree/blackberry/PNGImageEncoder.cpp:27
>> +#endif
> 
> Is this block really needed now that you got rid of Skia below?

I copied the PNGImageEncoder.cpp/h files from master_40 and added them to the patch. But yes, they can be removed.

>> Tools/DumpRenderTree/blackberry/build:4
>> +# the ~/dev/webplatform/tools/binding_generator folder.
> 
> These two lines are not relevant, please remove.

OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.