[Webkit-unassigned] [Bug 100066] [EFL][WK2] Add APIs to get/set the encoding detector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 25 08:59:34 PDT 2012


--- Comment #2 from Jinwoo Song <jinwoo7.song at samsung.com>  2012-10-25 09:00:41 PST ---
(From update of attachment 170062)
View in context: https://bugs.webkit.org/attachment.cgi?id=170062&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL][WK2] Add APIs to get/set encoding detector

This patch not only adds ewk setting APIs but also adds WKPreference APIs.
So it is not proper to add [EFL] prefix to the title.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:165
> +    ASSERT_FALSE(ewk_setting_uses_encoding_detector_get(settings));

It would be better to add comments that the default setting value is 'false' to explain why ASSERT_FALSE() is used.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list