[Webkit-unassigned] [Bug 100210] [BlackBerry] Support pixel tests for BlackBerry DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100210


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #170605|review?                     |review+
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-10-25 07:59:35 PST ---
(From update of attachment 170605)
View in context: https://bugs.webkit.org/attachment.cgi?id=170605&action=review

Looks good, please fix before landing.

> Source/WebKit/ChangeLog:8
> +        Adds a step to build ImageDiff from Qt for DRT.

In general you probably want to credit Chris Wells, he did most of this patch AFAIK.

> Tools/DumpRenderTree/blackberry/PNGImageEncoder.cpp:27
> +#endif

Is this block really needed now that you got rid of Skia below?

> Tools/DumpRenderTree/blackberry/build:4
> +# the ~/dev/webplatform/tools/binding_generator folder.

These two lines are not relevant, please remove.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.