[Webkit-unassigned] [Bug 99588] Use the new forwarder2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99588





--- Comment #13 from Peter Beverloo <peter at chromium.org>  2012-10-25 04:04:07 PST ---
(From update of attachment 170600)
View in context: https://bugs.webkit.org/attachment.cgi?id=170600&action=review

Thanks Felipe! A few more comments.

> Tools/ChangeLog:8
> +        It’s currently not possible to run the Clank test suite on

nit: It's.

"Clank"? I'm fairly sure you mean WebKit's layout tests..

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:42
> +from webkitpy.thirdparty.autoinstalled import pexepct

s/pexepct/pexpect. Please be sure to test the change locally as well.

> Tools/Scripts/webkitpy/thirdparty/__init__.py:77
> +        if '.pexpect' in fullname:

Assuming we can indeed land MIT code, it should be fine to add the pexpect library in Tools/Scripts/webkitpy/thirdparty/ directly. This should be done in a separate change, however.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.